Re: [Qemu-devel] [PATCH v7 08/10] docker: Add "images" subcommand to docker.py

[Alex Bennée]

Fam Zheng <address@hidden> writes:

> This is a wrapper for the 'docker images' command.
>
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  tests/docker/docker.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 40bda9d..222a105 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -179,6 +179,9 @@ class Docker(object):
>              self._instances.remove(label)
>          return ret
>
> +    def command(self, cmd, argv, quiet):
> +        return self._do([cmd] + argv, quiet=quiet)
> +
>  class SubCommand(object):
>      """A SubCommand template base class"""
>      name = None # Subcommand name
> @@ -309,6 +312,12 @@ class CleanCommand(SubCommand):
>          Docker().clean()
>          return 0
>
> +class ImagesCommand(SubCommand):
> +    """Run "docker images" command"""
> +    name = "images"
> +    def run(self, args, argv):
> +        return Docker().command("images", argv, args.quiet)
> +
>  def main():
>      parser = argparse.ArgumentParser(description="A Docker helper",
>              usage="%s <subcommand> ..." % os.path.basename(sys.argv[0]))


--
Alex Bennée