[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/10] docker: Don't start a container that doesn't e
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL 09/10] docker: Don't start a container that doesn't exist |
Date: |
Tue, 19 Jul 2016 22:31:16 +0800 |
Image building targets are dependencies of test running targets, so when
a docker image doesn't exist, it means it's skipped (due to dependency
checks in pre script). Therefore, skip the test too.
Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
---
tests/docker/Makefile.include | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index c5546ee..e7f0023 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -105,7 +105,10 @@ docker-run-%: docker-qemu-src
fi
$(if $(filter $(TESTS),$(CMD)),$(if $(filter $(IMAGES),$(IMAGE)), \
$(call quiet-command,\
- $(SRC_PATH)/tests/docker/docker.py run $(if $V,,--rm) \
+ if $(SRC_PATH)/tests/docker/docker.py images \
+ --format={{.Repository}}:{{.Tag}} | \
+ grep -qx qemu:$(IMAGE); then \
+ $(SRC_PATH)/tests/docker/docker.py run $(if
$V,,--rm) \
-t \
$(if $(DEBUG),-i,--net=none) \
-e TARGET_LIST=$(TARGET_LIST) \
@@ -117,6 +120,7 @@ docker-run-%: docker-qemu-src
qemu:$(IMAGE) \
/var/tmp/qemu/run \
$(CMD); \
+ fi \
, " RUN $(CMD) in $(IMAGE)")))
docker-clean:
--
2.7.4
- [Qemu-devel] [PULL 00/10] Docker patches, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 01/10] tests/docker/docker.py: docker_dir outside build, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 02/10] tests/docker/docker.py: support --include-executable, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 03/10] tests/docker/docker.py: check and run .pre script, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 07/10] docker: Fix exit code if $CMD failed, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 08/10] docker: Add "images" subcommand to docker.py, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 09/10] docker: Don't start a container that doesn't exist,
Fam Zheng <=
- [Qemu-devel] [PULL 06/10] docker: More sensible run script, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 04/10] tests/docker/dockerfiles: new debian-bootstrap.docker, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 10/10] docker: pass EXECUTABLE to build script, Fam Zheng, 2016/07/19
- [Qemu-devel] [PULL 05/10] tests/docker/docker.py: add update operation, Fam Zheng, 2016/07/19
- Re: [Qemu-devel] [PULL 00/10] Docker patches, Peter Maydell, 2016/07/20