[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drive
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers |
Date: |
Tue, 19 Jul 2016 16:42:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 19/07/2016 15:47, Colin Lord wrote:
> However, the protocol drivers do tend to see noticeable performance
> benefits. Most of them get modularized in the first three patches of
> this series. This includes the iscsi, glusterfs, ssh, curl, and rbd
> drivers.
Indeed, but... protocol drivers don't have probes, do they? There is a
distinction between "formats" and "protocols", and only formats need to
be probed for.
> A minimal configuration excluding all of these drivers takes
> around 3 ms to reach main(), and each of these drivers respectively add
> times of approximately 0.2, 0.9, 1.2, 2.5, and a massive time of 41.6 ms
> to the time to main. So some of these aren't even a huge benefit by
> themselves but they do add up, and also it makes sense to modularize all
> of the protocol drivers if we're already modularizing one.
All this I entirely agree with.
Paolo
- [Qemu-devel] [PATCH v4 20/32] blockdev: Separate dmg probe from its driver, (continued)
- [Qemu-devel] [PATCH v4 20/32] blockdev: Separate dmg probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 23/32] blockdev: Separate qcow2 probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 18/32] blockdev: Separate cloop probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 22/32] blockdev: Separate qcow probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 29/32] blockdev: Separate vpc probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 28/32] blockdev: Separate vmdk probe from its driver, Colin Lord, 2016/07/14
- Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers, Paolo Bonzini, 2016/07/19
- Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers, Max Reitz, 2016/07/22