Re: [Qemu-devel] [PULL 09/12] Move README to markdown

[Peter Maydell]

On 19 July 2016 at 19:15, Pranith Kumar <address@hidden> wrote:
> On Tue, Jul 19, 2016 at 11:49 AM, Daniel P. Berrange
> <address@hidden> wrote:
>> On Tue, Jul 19, 2016 at 10:34:16AM +0200, Paolo Bonzini wrote:
>>> From: Pranith Kumar <address@hidden>
>>>
>>> Move the README file to markdown so that it makes the github page look
>>> prettier. I know that github repo is a mirror and not the official
>>> repo, but I think it doesn't hurt to have it in markdown format.
>>>
>>> Signed-off-by: Pranith Kumar <address@hidden>
>>> Message-Id: <address@hidden>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> ---
>>>  README => README.md | 41 ++++++++++++++++++++---------------------
>>>  1 file changed, 20 insertions(+), 21 deletions(-)
>>>  rename README => README.md (85%)
>>
>> This has broken checkpatch.pl I'm afraid
>>
>>   $ git show 724b36ac355895953662d3ba41901873d66c0679  | perl 
>> ./scripts/checkpatch.pl -
>>   Must be run from the top-level dir. of a kernel tree
>>
>>
>> It seems "README" is one of the filenames checkpatch.pl requirs to
>> be present.
>>
>
> Hmm, my mistake. I thought changing README would not require running
> checkpatch since we are not touching any source.
>
> I wonder why that requirement exists.

checkpatch is trying to determine whether you've run it
from the right directory, so it just looks for some
files we know to exist in the QEMU source tree. It
doesn't try to do anything with them.

thanks
-- PMM