Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq

[Eric Blake]

On 07/19/2016 02:54 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> qemu_irq is already a pointer, no need to have an extra pointer level.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/i386/pc.c         | 8 ++++----
>  hw/input/pckbd.c     | 4 ++--
>  include/hw/i386/pc.h | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 1b8baa8..57b09c9 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -533,9 +533,9 @@ static uint64_t port92_read(void *opaque, hwaddr addr,
>      return ret;
>  }
>  
> -static void port92_init(ISADevice *dev, qemu_irq *a20_out)
> +static void port92_init(ISADevice *dev, qemu_irq a20_out)

qemu_irq type naming goes against our normal conventions.  But this
isn't the series to change that.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature