[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirro
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit |
Date: |
Tue, 19 Jul 2016 20:20:54 -0400 |
From: "Denis V. Lunev" <address@hidden>
There is no need to scan allocation tables if we have mark_all_dirty flag
set. Just mark it all dirty.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-id: address@hidden
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
CC: Jeff Cody <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>
---
block/mirror.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 0e74666..b7b1ded 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -533,11 +533,15 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob
*s)
BlockDriverState *base = s->base;
BlockDriverState *bs = blk_bs(s->common.blk);
BlockDriverState *target_bs = blk_bs(s->target);
- bool mark_all_dirty = base == NULL && !bdrv_has_zero_init(target_bs);
int ret, n;
end = s->bdev_length / BDRV_SECTOR_SIZE;
+ if (base == NULL && !bdrv_has_zero_init(target_bs)) {
+ bdrv_set_dirty_bitmap(s->dirty_bitmap, 0, end);
+ return 0;
+ }
+
/* First part, loop on the sectors and initialize the dirty bitmap. */
for (sector_num = 0; sector_num < end; ) {
/* Just to make sure we are not exceeding int limit. */
@@ -556,7 +560,7 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob *s)
}
assert(n > 0);
- if (ret == 1 || mark_all_dirty) {
+ if (ret == 1) {
bdrv_set_dirty_bitmap(s->dirty_bitmap, sector_num, n);
}
sector_num += n;
--
1.9.3
- [Qemu-devel] [PULL 00/14] Block patches, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 02/14] mirror: make sectors_in_flight int64_t, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 03/14] mirror: create mirror_throttle helper, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 04/14] mirror: create mirror_dirty_init helper for mirror_run, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 01/14] dirty-bitmap: operate with int64_t amount, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 05/14] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit,
Jeff Cody <=
- [Qemu-devel] [PULL 08/14] mirror: improve performance of mirroring of empty disk, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 07/14] mirror: efficiently zero out target, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 09/14] mirror: fix request throttling in drive-mirror, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 10/14] block/gluster: rename [server, volname, image] -> [host, volume, path], Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 11/14] block/gluster: code cleanup, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 12/14] block/gluster: deprecate rdma support, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 14/14] block/gluster: add support for multiple gluster servers, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema, Jeff Cody, 2016/07/19