[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on moder
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines |
Date: |
Wed, 20 Jul 2016 11:43:06 +0200 |
Hi,
> >> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing
> >> it.
> >
> > I think we should simply drop the flags and use bool variables instead.
> >
>
> You mean OnOffAuto new fields, right?
> We would need a wrapper since "auto" mode is not an actual value.
> But is doable, of course.
I was thinking about new variables, set to true for "on", false for
"off", and whatever we want do by default for "auto".
But moving that evaluation to small wrapper functions and just call them
when needed (which shouldn't be that often) instead of storing the
evaluation result in variables is fine too.
cheers,
Gerd