[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect() |
Date: |
Thu, 21 Jul 2016 08:42:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/21/2016 04:33 AM, Cao jin wrote:
> It is never used, and now all connect is nonblocking via
> inet_connect_addr().
>
Could be squashed with 1/2. In fact, if you squash it, I'd title the patch:
util: Drop unused *_nonblocking_connect() functions
You may also want to call out which commit id rendered the functions unused.
> Cc: Daniel P. Berrange <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> include/qemu/sockets.h | 3 ---
> util/qemu-sockets.c | 16 ----------------
> 2 files changed, 19 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Cao jin, 2016/07/21
- [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/21
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(),
Eric Blake <=
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/21
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
[Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect(), Cao jin, 2016/07/21
Re: [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Cao jin, 2016/07/21
Re: [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Paolo Bonzini, 2016/07/21