[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v4 40/57] Revert "mirror: Workaround for unexpected i
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v4 40/57] Revert "mirror: Workaround for unexpected iohandler events during completion" |
Date: |
Thu, 21 Jul 2016 19:29:20 +0300 |
From: Fam Zheng <address@hidden>
This reverts commit ab27c3b5e7408693dde0b565f050aa55c4a1bcef.
The virtio storage device host notifiers now work with
bdrv_drained_begin/end, so we don't need this hack any more.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
---
block/mirror.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index b1e633e..9ae11e5 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -508,9 +508,6 @@ static void mirror_exit(BlockJob *job, void *opaque)
block_job_completed(&s->common, data->ret);
g_free(data);
bdrv_drained_end(src);
- if (qemu_get_aio_context() == bdrv_get_aio_context(src)) {
- aio_enable_external(iohandler_get_aio_context());
- }
bdrv_unref(src);
}
@@ -734,12 +731,6 @@ immediate_exit:
/* Before we switch to target in mirror_exit, make sure data doesn't
* change. */
bdrv_drained_begin(bs);
- if (qemu_get_aio_context() == bdrv_get_aio_context(bs)) {
- /* FIXME: virtio host notifiers run on iohandler_ctx, therefore the
- * above bdrv_drained_end isn't enough to quiesce it. This is ugly, we
- * need a block layer API change to achieve this. */
- aio_disable_external(iohandler_get_aio_context());
- }
block_job_defer_to_main_loop(&s->common, mirror_exit, data);
}
--
MST
- [Qemu-devel] [PULL v4 31/57] kvm-irqchip: x86: add msi route notify fn, (continued)
- [Qemu-devel] [PULL v4 31/57] kvm-irqchip: x86: add msi route notify fn, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 30/57] kvm-irqchip: i386: add hook for add/remove virq, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 32/57] kvm-irqchip: do explicit commit when update irq, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 33/57] intel_iommu: support all masks in interrupt entry cache invalidation, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 34/57] kvm-all: add trace events for kvm irqchip ops, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 35/57] intel_iommu: disallow kernel-irqchip=on with IR, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 36/57] virtio: Add typedef for handle_output, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 37/57] virtio: Introduce virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 39/57] virtio-scsi: Call virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 38/57] virtio-blk: Call virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 40/57] Revert "mirror: Workaround for unexpected iohandler events during completion",
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v4 41/57] virtio-scsi: Replace HandleOutput typedef, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 42/57] virtio-net: Remove old migration version support, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 43/57] virtio-serial: Remove old migration version support, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 44/57] virtio: Migration helper function and macro, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 45/57] virtio-scsi: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 47/57] virtio-rng: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 48/57] virtio-balloon: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 46/57] virtio-blk: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 49/57] virtio-net: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21
- [Qemu-devel] [PULL v4 50/57] virtio-serial: Wrap in vmstate, Michael S. Tsirkin, 2016/07/21