[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup |
Date: |
Thu, 21 Jul 2016 17:21:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/21/2016 01:40 PM, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> Now that we can support boxed commands, use it to greatly reduce the
> number of parameters (and likelihood of getting out of sync) when
> adjusting drive-backup parameters..
s/.././
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: John Snow <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 115
> +++++++++++++++++----------------------------------
> hmp.c | 29 ++++++++-----
> qapi/block-core.json | 3 +-
> 3 files changed, 58 insertions(+), 89 deletions(-)
>
> +++ b/hmp.c
> @@ -1109,8 +1109,24 @@ void hmp_drive_backup(Monitor *mon, const QDict *qdict)
> const char *format = qdict_get_try_str(qdict, "format");
> bool reuse = qdict_get_try_bool(qdict, "reuse", false);
> bool full = qdict_get_try_bool(qdict, "full", false);
> - enum NewImageMode mode;
> Error *err = NULL;
> + DriveBackup backup = {
> + .device = (char *)device,
> + .target = (char *)filename,
> + .has_format = !!format,
> + .format = (char *)format,
> + .sync = full ? MIRROR_SYNC_MODE_FULL : MIRROR_SYNC_MODE_TOP,
> + .has_mode = true,
> + .mode = reuse ? NEW_IMAGE_MODE_EXISTING :
> NEW_IMAGE_MODE_ABSOLUTE_PATHS,
Good.
> + .has_speed = false,
> + .speed = 0,
> + .has_bitmap = false,
> + .bitmap = NULL,
> + .has_on_source_error = false,
> + .on_source_error = 0,
> + .has_on_target_error = false,
> + .on_target_error = 0,
I'd drop these. C guarantees that they'll be zero-initialized, and
unless HMP has a way to set them to non-default values, it's not worth
wasting the lines of code.
With those fixups,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/16] backup compression, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 10/16] block/io: turn on dirty_bitmaps for the compressed writes, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 06/16] vmdk: add vmdk_co_pwritev_compressed, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup, Denis V. Lunev, 2016/07/21
- Re: [Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup,
Eric Blake <=
- [Qemu-devel] [PATCH v6 04/16] qcow2: add qcow2_co_pwritev_compressed, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 08/16] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 03/16] block/io: reuse bdrv_co_pwritev() for write compressed, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 16/16] qemu-iotests: add vmdk for test backup compression in 055, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 05/16] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 09/16] block: remove BlockDriver.bdrv_write_compressed, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 12/16] block: simplify blockdev-backup, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 15/16] qemu-iotests: test backup compression in 055, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 13/16] drive-backup: added support for data compression, Denis V. Lunev, 2016/07/21
- [Qemu-devel] [PATCH v6 01/16] block: switch blk_write_compressed() to byte-based interface, Denis V. Lunev, 2016/07/21