[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.7 v2] block/gluster: fix doc in the qapi s
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.7 v2] block/gluster: fix doc in the qapi schema and member name |
|
Date: |
Fri, 22 Jul 2016 08:46:18 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote:
> 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/
> 2. rearrange the versioning
> 3. s/server description/servers description/
>
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
This part is fine.
> v2: address review comments given by Eric Blake
> v1: Initial patch
But these lines...
> ---
...should be here. They are useful to reviewers, but do not need to
clutter qemu.git, so putting them after the separator lets 'git am'
automatically strip them.
The maintainer can probably fix that without needing a respin.
> qapi/block-core.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
Must go in during hard freeze for 2.7, otherwise it would be an ABI
change compared to released code.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature