|
From: | Corey Minyard |
Subject: | Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize |
Date: | Sat, 23 Jul 2016 08:18:34 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 07/23/2016 02:46 AM, Paolo Bonzini wrote:
On 22/07/2016 21:50, address@hidden wrote:This has kind of opened a can of worms for me, though. Looking at a lot of the devices, there is no unrealize function and that can leave a lot of things hanging. And for ISA bus devices, there is no way to unregister ports.Right, this is because they aren't hotpluggable. I should dig out the huge patchset I had to make timers statically allocated... Paolo
Am I correct in saying, then, that instead of adding a finalize function to the IPMI BMC, we should instead make it not hot pluggable? And then the rest of my patches are not really relevant. I already have a function to set hotpluggable to false for the BMCs, I can post that. From what I have seen, you can unrealize devices using the API, even if they are not hot pluggable, by setting the realized bool. Is that ok? -corey
[Prev in Thread] | Current Thread | [Next in Thread] |