Re: [Qemu-devel] [PATCH] fixup! fix qemu exit on memory hotplug when allocation fails at prealloc time

[Markus Armbruster]

Igor Mammedov <address@hidden> writes:

> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  - add comment o exit(1) path
> ---
>  util/oslib-posix.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index a60ac97..f2d4e9e 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -356,6 +356,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory, 
> Error **errp)
>  
>      ret = sigaction(SIGBUS, &oldact, NULL);
>      if (ret) {
> +        /* Terminate QEMU since it can't recover from error */
>          perror("os_mem_prealloc: failed to reinstall signal handler");
>          exit(1);
>      }

Thanks!  My R-by stands, of course.