Re: [Qemu-devel] [PATCH v3 07/15] target-ppc: implement branch-less divw[o][.]

[Richard Henderson]

On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote:
>      if (compute_ov) {
> -        tcg_gen_movi_tl(cpu_ov, 1);
> -        tcg_gen_movi_tl(cpu_so, 1);
> +        tcg_gen_extu_i32_tl(cpu_ov, t2);
> +        tcg_gen_extu_i32_tl(cpu_so, t2);
>      }

This should be

  tcg_gen_extu_i32_tl(cpu_ov, t2);
  tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);

I.e. the summary overflow accumulates.


r~