Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse

[Daniel P. Berrange]

On Tue, Jul 26, 2016 at 02:23:52AM +0200, Max Reitz wrote:
> On 22.07.2016 10:00, Amit Shah wrote:
> > From: "Daniel P. Berrange" <address@hidden>
> > 
> > The iotests module has a python class for controlling QEMU
> > processes. Pull the generic functionality out of this file
> > and create a scripts/qemu.py module containing a QEMUMachine
> > class. Put the QTest integration support into a subclass
> > QEMUQtestMachine.
> > 
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: Amit Shah <address@hidden>
> > ---
> >  scripts/qemu.py               | 202 
> > ++++++++++++++++++++++++++++++++++++++++++
> >  scripts/qtest.py              |  34 +++++++
> >  tests/qemu-iotests/iotests.py | 135 +---------------------------
> >  3 files changed, 240 insertions(+), 131 deletions(-)
> >  create mode 100644 scripts/qemu.py
> 
> Hm, I have even more questions...
> 
> (I'm starting to wonder if I'm doing anything horribly wrong, because
> this patch basically completely breaks the Python iotests for me.)

[snip]

I'll investigate this and send any neccessary fixes asap.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|