Re: [Qemu-devel] [PATCH v2 2/6] cadence_gem: Add the num-priority-queues property

[Peter Maydell]

On 26 July 2016 at 01:12, Alistair Francis <address@hidden> wrote:
> The Cadence GEM hardware supports N number priority queues, this patch is a
> step towards that by adding the property to set the queues. At the moment
> behaviour doesn't change as we only use queue 0.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---

> @@ -1218,7 +1220,7 @@ static void gem_realize(DeviceState *dev, Error **errp)
>  {
>      CadenceGEMState *s = CADENCE_GEM(dev);
>
> -    sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq);
> +    sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq[0]);
>
>      qemu_macaddr_default_if_unset(&s->conf.macaddr);

At some point realize() needs to error-check the num-priority-queues
property (ie check it isn't >8). Do you do that later in the series?
(if so fine, if not, this patch is as good a place as any to put it.)

> @@ -1243,13 +1245,15 @@ static void gem_init(Object *obj)
>  static const VMStateDescription vmstate_cadence_gem = {
>      .name = "cadence_gem",
>      .version_id = 2,
> -    .minimum_version_id = 2,
> +    .minimum_version_id = 3,

You need to bump .version_id too.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM