[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag |
Date: |
Tue, 26 Jul 2016 16:10:56 +0300 |
On Tue, Jul 26, 2016 at 04:48:06PM +0530, Amit Shah wrote:
> On (Tue) 26 Jul 2016 [15:29:36], Cao jin wrote:
> > Hi Amit
> >
> > I will take care of this.
> > BTW, did't see it in coverity scan outstanding defects, Do I missed or it is
> > checked by other static check tools?
>
> This is checked with the vmstate static checker --
> scripts/vmstate-static-checker.py.
>
> The -dump-vmstate cmdline option to qemu gives a json file that the
> static checker uses as input. Get a 'before' and 'after' version of
> the json files, and pass those on to the checker with '-s' and '-d'
> arguments respectively.
>
> Thanks,
>
> Amit
How about adding this to make check?
You can run this with a given machine type to avoid too much churn.
--
MST