[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v23 11/12] support replication driver in blockde
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add |
Date: |
Tue, 26 Jul 2016 18:22:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 26.07.2016 10:15, Changlong Xie wrote:
> From: Wen Congyang <address@hidden>
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Signed-off-by: Wang WeiWei <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> qapi/block-core.json | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 7258a87..48aa112 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -248,6 +248,7 @@
> # 2.3: 'host_floppy' deprecated
> # 2.5: 'host_floppy' dropped
> # 2.6: 'luks' added
> +# 2.8: 'replication' added
> #
> # @backing_file: #optional the name of the backing file (for copy-on-write)
> #
> @@ -1696,8 +1697,8 @@
> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
> - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
> - 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
> 'replication',
> + 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>
> ##
> # @BlockdevOptionsFile
> @@ -2160,6 +2161,22 @@
> { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>
> ##
> +# @BlockdevOptionsReplication
> +#
> +# Driver specific block device options for replication
> +#
> +# @mode: the replication mode
> +#
> +# @top-id: the id to protect replication model chain
It's hard for me to understand this sentence without reading the code
and thus knowing what this ID is used for. I'd use the following instead:
@top-id: In secondary mode, node name or device ID of the root node who
owns the replication node chain. Ignored in primary mode.
Also, since this parameter is only necessary in secondary mode and
completely ignored in primary mode, I would probably make it an optional
parameter.
Max
> +#
> +# Since: 2.8
> +##
> +{ 'struct': 'BlockdevOptionsReplication',
> + 'base': 'BlockdevOptionsGenericFormat',
> + 'data': { 'mode': 'ReplicationMode',
> + 'top-id': 'str' } }
> +
> +##
> # @BlockdevOptions
> #
> # Options for creating a block device. Many options are available for all
> @@ -2224,6 +2241,7 @@
> 'quorum': 'BlockdevOptionsQuorum',
> 'raw': 'BlockdevOptionsGenericFormat',
> # TODO rbd: Wait for structured options
> + 'replication':'BlockdevOptionsReplication',
> # TODO sheepdog: Wait for structured options
> # TODO ssh: Should take InetSocketAddress for 'host'?
> 'tftp': 'BlockdevOptionsFile',
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v23 04/12] Link backup into block core, (continued)
- [Qemu-devel] [PATCH v23 04/12] Link backup into block core, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 06/12] auto complete active commit, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 02/12] Backup: clear all bitmap when doing block checkpoint, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 08/12] Introduce new APIs to do replication operation, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 05/12] docs: block replication's description, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 07/12] configure: support replication, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add, Changlong Xie, 2016/07/26
- Re: [Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add,
Max Reitz <=
- [Qemu-devel] [PATCH v23 09/12] Implement new driver for block replication, Changlong Xie, 2016/07/26
- [Qemu-devel] [PATCH v23 10/12] tests: add unit test case for replication, Changlong Xie, 2016/07/26