qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/32] ppc: Make float_check_status() pass the r


From: Benjamin Herrenschmidt
Subject: Re: [Qemu-devel] [PATCH 10/32] ppc: Make float_check_status() pass the return address
Date: Wed, 27 Jul 2016 13:47:59 +1000

On Wed, 2016-07-27 at 11:57 +1000, David Gibson wrote:
> > -void helper_float_check_status(CPUPPCState *env)
> > +static __attribute__((noinline)) void
> do_float_check_status(CPUPPCState *env,
> > +                                                           
> uintptr_t raddr)
> 
> Why do you need to force this to be non-inline?

I don't. It just that gcc inlines too much shit :-)

In fact I had a patch at some point that made a whole pile of stuff in
translate.c non-inline and that reduced the size of it by about 100K

But yeah, I can drop it for now, it's irrelevant to the point of the
patch.

Cheers,
ben.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]