Re: [Qemu-devel] [PATCH] ipmi: Remove hotplug from IPMI BMCs

[Marc-André Lureau]

Hi

----- Original Message -----
> From: Corey Minyard <address@hidden>
> 
> No hotplug support, make sure it doesn't happen.
> 
> Signed-off-by: Corey Minyard <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  hw/ipmi/ipmi_bmc_extern.c | 1 +
>  hw/ipmi/ipmi_bmc_sim.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> This is my proposed patch instead of "ipmi:free extern timer"
> send by Marc-Andre.
> 
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index 157879e..ebd0d8d 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -499,6 +499,7 @@ static void ipmi_bmc_extern_class_init(ObjectClass *oc,
> void *data)
>  
>      bk->handle_command = ipmi_bmc_extern_handle_command;
>      bk->handle_reset = ipmi_bmc_extern_handle_reset;
> +    dc->hotpluggable = false;
>      dc->realize = ipmi_bmc_extern_realize;
>      dc->props = ipmi_bmc_extern_properties;
>  }
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index dc9c14c..190e169 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -1791,6 +1791,7 @@ static void ipmi_sim_class_init(ObjectClass *oc, void
> *data)
>      DeviceClass *dc = DEVICE_CLASS(oc);
>      IPMIBmcClass *bk = IPMI_BMC_CLASS(oc);
>  
> +    dc->hotpluggable = false;
>      dc->realize = ipmi_sim_realize;
>      bk->handle_command = ipmi_sim_handle_command;
>  }
> --
> 2.7.4
> 
>