Re: [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use

[Alexey Kardashevskiy]

On 27/07/16 23:32, Peter Xu wrote:
> On Wed, Jul 27, 2016 at 09:29:07PM +0800, Peter Xu wrote:
> 
> [...]
> 
>>> This works too.
>>>
>>> You may also want to copy if(!kvm_gsi_routing_enabled()) from
>>> kvm_irqchip_add_msi_route() to align API (not needed in my case though). Or
>>> just check the result of these checks by if(!s->irq_routes) :)
>>> Thanks.
>>
>> Right. Do you like to post a v2 for this one? (since of course honor
>> is yours and fault is mine :) Please let me know if you want me to do
>> this for you. It'll be nice we have this fix asap so that less people
>> suffers.
> 
> Btw, please ignore above message if you still prefer v1 and sure that
> it works in all cases. :)


I am totally fine with either fix (others may have opinions though), if you
really want your fix, please do so (and you can quote me as
"Reported-by"/"Tested-by" if you feel guilt which I do not think you should) :)



-- 
Alexey