Re: [Qemu-devel] [Qemu-block] [PATCH v6] qemu-img: add the 'dd' subcommand

[Stefan Hajnoczi]

On Mon, Jul 25, 2016 at 6:58 AM, Reda Sallahi <address@hidden> wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tty, pipes, etc.
>
> The image format must be specified with -O for the output if the raw format
> is not the intended one.
>
> Two tests are added to test qemu-img dd.
>
> Signed-off-by: Reda Sallahi <address@hidden>
> ---
> Changes from v5:
> * Add dd sections on qemu-img.texi.
> Changes from v4:
> * Fix the exit status.
> Changes from v3:
> * Delete an unused (so far) field in DdIo.
> Changes from v2:
> * Add copyright headers to new files.
> Changes from v1:
> * Removal of dead code.
> * Fix a memory leak.
> * Complete the cleanup function in the test cases.
>
>  qemu-img-cmds.hx                 |   6 +
>  qemu-img.c                       | 363 
> ++++++++++++++++++++++++++++++++++++++-
>  qemu-img.texi                    |  25 +++
>  tests/qemu-iotests/158           |  68 ++++++++
>  tests/qemu-iotests/158.out       |  15 ++
>  tests/qemu-iotests/159           |  70 ++++++++
>  tests/qemu-iotests/159.out       |  87 ++++++++++
>  tests/qemu-iotests/common.filter |   9 +
>  tests/qemu-iotests/group         |   2 +
>  9 files changed, 644 insertions(+), 1 deletion(-)
>  create mode 100755 tests/qemu-iotests/158
>  create mode 100644 tests/qemu-iotests/158.out
>  create mode 100755 tests/qemu-iotests/159
>  create mode 100644 tests/qemu-iotests/159.out

Reviewed-by: Stefan Hajnoczi <address@hidden>