Re: [Qemu-devel] ui/cocoa.m: Make a better about dialog

[Peter Maydell]

On 28 July 2016 at 15:42, Programmingkid <address@hidden> wrote:
> From 0c803fd07ddf05904d283628f8277b14fb8cbf35 Mon Sep 17 00:00:00 2001
> From: John Arbuckle <address@hidden>
> Date: Thu, 28 Jul 2016 10:34:33 -0400
> Subject: [PATCH] Make a better about dialog
>
> The about dialog in QEMU on Mac OS X is very plain and unhelpful. This patch
> makes the about dialog look a lot better and have some descriptive information
> on what version of QEMU the user is running.
>
> Signed-off-by: John Arbuckle <address@hidden>
>

> +    /* Remove the parenthese and first 'v' character */
> +    char buffer[100];
> +    sprintf(buffer, "%s", QEMU_PKGVERSION);
> +    snprintf(buffer, strlen(buffer) - 3, "%s", (buffer+3));

You've missed QEMU_VERSION. Just print
QEMU_VERSION QEMU_PKGVERSION, like the -version output does.

thanks
-- PMM