[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction
|
From: |
Nikunj A Dadhania |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction |
|
Date: |
Thu, 28 Jul 2016 23:03:25 +0530 |
|
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Richard Henderson <address@hidden> writes:
> On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
>> + tcg_gen_ext32s_tl(dst, src);
>> + if (sh != 0) {
>> + tcg_gen_shli_tl(dst, dst, sh);
>> + }
>
> You need not test for sh != 0, since that will be done in
> tcg_gen_shli_tl.
Sure, will updated.
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
- Re: [Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions, (continued)