[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machin
From: |
Emil Condrea |
Subject: |
Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part) |
Date: |
Sun, 31 Jul 2016 12:57:59 +0300 |
Thanks Anthony for the feedback.
I will send v10 containing fixes for patches 1 to 12 + additional patches
for
fixing code style issues for moved code.
On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD <address@hidden>
wrote:
> On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote:
> > Emil Condrea (19):
> > xen: Create a new file xen_pvdev.c
> > xen: Create a new file xen_frontend.c
> > xen: Move xenstore_update to xen_pvdev.c
> > xen: Move evtchn functions to xen_pvdev.c
> > xen: Prepare xendev qtail to be shared with frontends
> > xen: Rename xen_be_printf to xen_pv_printf
> > xen: Rename xen_be_unbind_evtchn
> > xen: Rename xen_be_send_notify
> > xen: Rename xen_be_evtchn_event
> > xen: Rename xen_be_find_xendev
> > xen: Rename xen_be_del_xendev
> > xen: Rename xen_be_frontend_changed
>
> Patches from 1 to 12 looks fine but ./script/checkpatch.pl reveal some
> coding style issue in the code that is moved. Could you fix those issues
> in separate patches? (Having separate patches for code movement and for
> coding style fix makes it easier to review.)
>
> I'll start reviewing the more complicated patches now.
>
> Thanks,
>
> --
> Anthony PERARD
>
- [Qemu-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure, (continued)
- [Qemu-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 19/19] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init(), Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 17/19] Qemu-Xen-vTPM: Move tpm_passthrough_is_selftest() into tpm_util.c, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 16/19] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 18/19] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backend, Emil Condrea, 2016/07/10
- Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part), Xu, Quan, 2016/07/12
- Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part), Anthony PERARD, 2016/07/25
- Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part),
Emil Condrea <=