Re: [Qemu-devel] [Patch v1 15/29] s390x/sclp: indicate sclp features

[David Hildenbrand]

> > +void s390_get_feat_block(S390FeatType type, uint8_t *data)
> > +{
> > +    static S390CPU *cpu;
> > +
> > +    if (!cpu) {
> > +        cpu = S390_CPU(qemu_get_cpu(0));
> > +    }
> > +
> > +    if (!cpu || !cpu->model) {
> > +        return;
> > +    }
> > +    return s390_fill_feat_block(cpu->model->features, type, data);  
> 
> IMHO it's somewhat strange to write "return something()" in a function
> that has been declared as "void". I know GCC does not reject this, but
> anyway, I'd suggest to simply remove the "return" keyword here.
> 
>  Thomas

Yes, that looks like a leftover, thanks Thomas!

David