qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragment length during fragm


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH] net: vmxnet: check fragment length during fragmentation
Date: Thu, 4 Aug 2016 13:36:44 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 2016年08月02日 19:37, P J P wrote:
From: Prasad J Pandit <address@hidden>

VMware VMXNET* NIC emulator supports packet fragmentation.
While fragmenting a packet, it checks for more fragments based
on packet length and current fragment length. It is susceptible
to an infinite loop, if the current fragment length is zero.
Add check to avoid it.

Reported-by: Li Qiang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
  hw/net/vmxnet_tx_pkt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/vmxnet_tx_pkt.c b/hw/net/vmxnet_tx_pkt.c
index 91e1e08..f4d0f5f 100644
--- a/hw/net/vmxnet_tx_pkt.c
+++ b/hw/net/vmxnet_tx_pkt.c
@@ -544,7 +544,7 @@ static bool vmxnet_tx_pkt_do_sw_fragmentation(struct 
VmxnetTxPkt *pkt,
fragment_offset += fragment_len; - } while (more_frags);
+    } while (fragment_len && more_frags);
return true;
  }

The patch doesn't apply cleanly on HEAD, we now move this logic to hw/net/net_tx_pkt.c. Please resend on top of HEAD and cc Dmitry Fleytman <address@hidden>.

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]