Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

[Tian, Kevin]

> From: Kirti Wankhede [mailto:address@hidden
> Sent: Thursday, August 04, 2016 3:04 AM
> 
> 
> 2. Physical device driver interface
> This interface provides vendor driver the set APIs to manage physical
> device related work in their own driver. APIs are :
> - supported_config: provide supported configuration list by the vendor
>                   driver
> - create: to allocate basic resources in vendor driver for a mediated
>         device.
> - destroy: to free resources in vendor driver when mediated device is
>          destroyed.
> - reset: to free and reallocate resources in vendor driver during reboot

Currently I saw 'reset' callback only invoked from VFIO ioctl path. Do 
you think whether it makes sense to expose a sysfs 'reset' node too,
similar to what people see under a PCI device node?

> - start: to initiate mediated device initialization process from vendor
>        driver
> - shutdown: to teardown mediated device resources during teardown.

I think 'shutdown' should be 'stop' based on actual code.

Thanks
Kevin