Re: [Qemu-devel] [Patch v1 26/29] qmp: add QMP interface "query-cpu-model-baseline"

[David Hildenbrand]

> +##
> +# @query-cpu-model-baseline:
> +#
> +# Baseline two CPU models, creating a compatible third model. The created
> +# model will always be a static, migration-safe CPU model (see "static"
> +# CPU model expansion for details). The QEMU machine QEMU has been started
> +# with affects the result if CPU definitions are used that are not static.
> +#
> +# Note: This interface should not be used when global properties of CPU 
> classes
> +#       are changed (e.g. via "-cpu ...").
> +#
> +# s390x supports baselining of all CPU models. Other architectures are not
> +# supported yet.
> +#
> +# Returns: a CpuModelBaselineInfo. Returns an error if baselining CPU models 
> is
> +#          not supported, if a model cannot be used, if a model contains
> +#          an unknown cpu definition name, unknown properties or properties
> +#          with wrong types.
> +#
> +# Since: 2.8.0
> +##


This comment is now:

##                                                                              
    
# @query-cpu-model-baseline:                                                    
    
#                                                                               
    
# Baseline two CPU models, creating a compatible third model. The created       
    
# model will always be a static, migration-safe CPU model (see "static"         
    
# CPU model expansion for details).                                             
    
#                                                                               
    
# This interface can be used by tooling to create a compatible CPU model out    
# two CPU models. The created CPU model will be identical to or a subset of     
# both CPU models when comparing them. Therefore, the created CPU model is      
    
# guaranteed to run where the given CPU models run.                             
    
#                                                                               
    
# The result returned by this command may be affected by:                       
    
#                                                                               
    
# * QEMU version: CPU models may look different depending on the QEMU version.  
#   (Except for CPU models reported as "static" in query-cpu-definitions.)      
    
# * machine-type: CPU model  may look different depending on the machine-type.  
#   (Except for CPU models reported as "static" in query-cpu-definitions.)      
    
# * machine options (including accelerator): in some architectures, CPU models  
#   may look different depending on machine and accelerator options. (Except for
#   CPU models reported as "static" in query-cpu-definitions.)                  
    
# * "-cpu" arguments and global properties: arguments to the -cpu option and    
#   global properties may affect expansion of CPU models. Using                 
    
#   query-cpu-model-expansion while using these is not advised.                 
    
#                                                                               
    
# Some architectures may not support baselining CPU models. s390x supports      
    
# baselining CPU models.                                                        
    
#                                                                               
    
# Returns: a CpuModelBaselineInfo. Returns an error if baselining CPU models is 
#          not supported, if a model cannot be used, if a model contains        
    
#          an unknown cpu definition name, unknown properties or properties     
#          with wrong types.                                                    
    
#                                                                               
    
# Since: 2.8.0                                                                  
    
##      

David