[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very larg
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very large sizes |
Date: |
Thu, 4 Aug 2016 17:15:05 +0300 |
From: Peter Maydell <address@hidden>
In do_brk(), we were inadvertently truncating the size
of a requested brk() from the guest by putting it into an
'int' variable. This meant that we would incorrectly report
success back to the guest rather than a failed allocation,
typically resulting in the guest then segfaulting. Use
abi_ulong instead.
This fixes a crash in the '31370.cc' test in the gcc libstdc++ test
suite (the test case starts by trying to allocate a very large
size and reduces the size until the allocation succeeds).
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index df6f2a9..833f853 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -839,7 +839,7 @@ void target_set_brk(abi_ulong new_brk)
abi_long do_brk(abi_ulong new_brk)
{
abi_long mapped_addr;
- int new_alloc_size;
+ abi_ulong new_alloc_size;
DEBUGF_BRK("do_brk(" TARGET_ABI_FMT_lx ") -> ", new_brk);
--
2.1.4
- [Qemu-devel] [PULL 0/5] linux-user fixes for 2.7, riku . voipio, 2016/08/04
- [Qemu-devel] [PULL 1/5] linux-user: Use correct alignment for long long on i386 guests, riku . voipio, 2016/08/04
- [Qemu-devel] [PULL 3/5] linux-user: Don't write off end of new_utsname buffer, riku . voipio, 2016/08/04
- [Qemu-devel] [PULL 4/5] linux-user: Fix target_semid_ds structure definition, riku . voipio, 2016/08/04
- [Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very large sizes,
riku . voipio <=
- [Qemu-devel] [PULL 2/5] linux-user: Fix memchr() argument in open_self_cmdline(), riku . voipio, 2016/08/04
- Re: [Qemu-devel] [PULL 0/5] linux-user fixes for 2.7, Peter Maydell, 2016/08/05