[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification |
Date: |
Thu, 4 Aug 2016 22:56:20 +0300 |
On Thu, Aug 04, 2016 at 11:24:26AM +0000, Gonglei (Arei) wrote:
> > > +The first driver-read-only field, \field{version} specifies the virtio
> > > crypto's
> > > +version, which is reserved for back-compatibility in future.It's
> > > currently
> > > +defined for the version field:
> > > +
> > > +\begin{lstlisting}
> > > +#define VIRTIO_CRYPTO_VERSION_1 (1)
> >
> > Suggest to remove this macro,
> > Do you think a version which is composed of major version and
> > minor version is better?
> >
>
> I think we should tell the developer how to set the value of version field,
> but I have no idea about which value or form is better, so I used 1 as the
> first version. What's your opinion?
My opinion is that you should drop this completely. We do feature bits,
not version numbers in virtio. We do not want each device doing its own
thing for compatibility.
--
MST
- [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification, Gonglei, 2016/08/01
- [Qemu-devel] [PATCH v6 2/2] virtio-crypto: add conformance clauses, Gonglei, 2016/08/01
- [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Gonglei, 2016/08/01
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/08/04
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Gonglei (Arei), 2016/08/04
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/08/08
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Cornelia Huck, 2016/08/09
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/08/09
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Michael S. Tsirkin, 2016/08/09
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/08/09
- Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification, Gonglei (Arei), 2016/08/09
Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification, Michael S. Tsirkin, 2016/08/03