[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] error: Fix error_printf() calls lacking new
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/4] error: Fix error_printf() calls lacking newlines |
|
Date: |
Fri, 05 Aug 2016 08:58:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/03/2016 05:37 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> hw/i386/pc.c | 2 +-
>> kvm-all.c | 2 +-
>> ui/vnc.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>
> I'm guessing these were found with a slight tweak to the Coccinelle
> script in 1/4? Worth checking that in, or at least leaving a comment
> bread-crumb?
I simply examined all error_printf() calls. Only 49. If the problem
persists, we may want to add a script to catch it.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!