qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] net: check fragment length during fragmentat


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH v2] net: check fragment length during fragmentation
Date: Fri, 5 Aug 2016 16:42:36 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 2016年08月04日 18:57, Dmitry Fleytman wrote:
Reviewed-by: Dmitry Fleytman <address@hidden <mailto:address@hidden>>

On Thu, Aug 4, 2016 at 12:30 AM, P J P <address@hidden <mailto:address@hidden>> wrote:

    From: Prasad J Pandit <address@hidden
    <mailto:address@hidden>>

    Network transport abstraction layer supports packet fragmentation.
    While fragmenting a packet, it checks for more fragments from
    packet length and current fragment length. It is susceptible
    to an infinite loop, if the current fragment length is zero.
    Add check to avoid it.

    Reported-by: Li Qiang <address@hidden <mailto:address@hidden>>
    Signed-off-by: Prasad J Pandit <address@hidden
    <mailto:address@hidden>>
    ---
     hw/net/net_tx_pkt.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    Updated as per
      ->
    https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg00751.html

    diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c
    index efd43b4..53dfaa2 100644
    --- a/hw/net/net_tx_pkt.c
    +++ b/hw/net/net_tx_pkt.c
    @@ -590,7 +590,7 @@ static bool
    net_tx_pkt_do_sw_fragmentation(struct NetTxPkt *pkt,

             fragment_offset += fragment_len;

    -    } while (more_frags);
    +    } while (fragment_len && more_frags);

         return true;
     }
    --
    2.5.5



Applied. Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]