[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits lower than t
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits lower than the normal limits |
Date: |
Fri, 5 Aug 2016 10:24:40 +0100 |
From: Alberto Garcia <address@hidden>
This checks that making FOO_max lower than FOO is not allowed.
We could also forbid having FOO_max == FOO, but that doesn't have
any odd side effects and it would require us to update several other
tests, so let's keep it simple.
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/test-throttle.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/test-throttle.c b/tests/test-throttle.c
index afe094b..363b59a 100644
--- a/tests/test-throttle.c
+++ b/tests/test-throttle.c
@@ -394,6 +394,14 @@ static void test_max_is_missing_limit(void)
cfg.buckets[i].max = 0;
cfg.buckets[i].avg = 100;
g_assert(throttle_is_valid(&cfg, NULL));
+
+ cfg.buckets[i].max = 30;
+ cfg.buckets[i].avg = 100;
+ g_assert(!throttle_is_valid(&cfg, NULL));
+
+ cfg.buckets[i].max = 100;
+ cfg.buckets[i].avg = 100;
+ g_assert(throttle_is_valid(&cfg, NULL));
}
}
--
2.7.4
- [Qemu-devel] [PULL for-2.7 0/5] Block patches, Stefan Hajnoczi, 2016/08/05
- [Qemu-devel] [PULL for-2.7 1/5] block/parallels: check new image size, Stefan Hajnoczi, 2016/08/05
- [Qemu-devel] [PULL for-2.7 2/5] throttle: Don't allow burst limits to be lower than the normal limits, Stefan Hajnoczi, 2016/08/05
- [Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits lower than the normal limits,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL for-2.7 5/5] virtio-blk: Remove stale comment about draining, Stefan Hajnoczi, 2016/08/05
- [Qemu-devel] [PULL for-2.7 4/5] virtio-blk: Release s->rq queue at system_reset, Stefan Hajnoczi, 2016/08/05
- Re: [Qemu-devel] [PULL for-2.7 0/5] Block patches, Peter Maydell, 2016/08/05