Re: [Qemu-devel] [PATCH for-2.7 2/2] audio: clean up before monitor clean up

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 01/08/2016 13:23, address@hidden wrote:
>> From: Marc-André Lureau <address@hidden>
>> 
>> Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu,
>> before the atexit() handlers. audio_cleanup() may use the monitor to
>> notify of changes. For compatibility reasons, let's clean up audio
>> before the monitor so it keeps emitting monitor events.
>> 
>> The audio_atexit() function is made idempotent (so it can be called
>> multiple times),
>
> That's a very good idea, as it avoids having to establish exit notifiers
> as we did for net/.
>
> Reviewed-by: Paolo Bonzini <address@hidden>

Does the R-by apply to PATCH 1/2 as well?

> The two patches conflict with each other, so it's probably easiest if
> one of Gerd or Markus takes both.

I can squeeze in review and a pull request today.  Gerd, if you'd prefer
to do it yourself, let me know.