[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast |
|
Date: |
Mon, 8 Aug 2016 12:02:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 08/08/2016 12:00, Richard Henderson wrote:
> On 08/08/2016 03:25 PM, Paolo Bonzini wrote:
>> +
>> __builtin_choose_expr( \
>> + __builtin_types_compatible_p(typeof(expr), const char)
>> || \
>> + __builtin_types_compatible_p(typeof(expr),
>> char), \
>> +
>> (char)1, \
>
> Better as signed char, since bare char could be either signed or unsigned.
It's also better to add a volatile case.
Paolo