Re: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast

[Richard Henderson]

On 08/08/2016 03:32 PM, Paolo Bonzini wrote:
> On 08/08/2016 12:00, Richard Henderson wrote:
> > On 08/08/2016 03:25 PM, Paolo Bonzini wrote:
> > > +
> > > __builtin_choose_expr(                                                 \
> > > +          __builtin_types_compatible_p(typeof(expr), const char)
> > > ||            \
> > > +            __builtin_types_compatible_p(typeof(expr),
> > > char),                  \
> > > +
> > > (char)1,                                                             \
> >
> > Better as signed char, since bare char could be either signed or unsigned.
>
> It's also better to add a volatile case.

... and, eventually, the _Atomic case.

I really should have finished the __typeof_noqual patch that I was working on 
some years ago...  Ho hum.


r~