[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 13/16] drive-backup: added support for data c
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v7 13/16] drive-backup: added support for data compression |
Date: |
Mon, 8 Aug 2016 16:10:14 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 08.08.2016 um 16:07 hat Kevin Wolf geschrieben:
> Am 22.07.2016 um 10:17 hat Denis V. Lunev geschrieben:
> > @@ -3317,7 +3320,7 @@ void do_blockdev_backup(BlockdevBackup *backup,
> > BlockJobTxn *txn, Error **errp)
> > }
> > }
> > backup_start(backup->job_id, bs, target_bs, backup->speed,
> > backup->sync,
> > - NULL, backup->on_source_error, backup->on_target_error,
> > + NULL, false, backup->on_source_error,
> > backup->on_target_error,
> > block_job_cb, bs, txn, &local_err);
> > if (local_err != NULL) {
> > error_propagate(errp, local_err);
>
> blockdev-backup is supposed to be the primary interface in the future,
> so I would like to avoid introducing a feature gap where drive-backup is
> more powerful. Can you please post a small diff to squash in so that
> this patch adds the option to both commands? Wiring this up should be
> trivial.
Never mind, you already do. Somehow I didn't expect it in a separate
patch. The series is fine as it is. :-)
Kevin