Re: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

[Fam Zheng]

On Mon, 08/08 06:59, address@hidden wrote:
> Checking PATCH 3/20: block: Add and parse "lock-mode" option for image 
> locking...
> ERROR: do not use assignment in if condition
> #80: FILE: blockdev.c:548:
> +    if ((buf = qemu_opt_get(opts, BDRV_OPT_LOCK_MODE)) != NULL) {
> 
> total: 1 errors, 0 warnings, 86 lines checked

I intentionally ignored this to be consistent with the several other occasions
in this function.

> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 4/20: block: Introduce image file locking...
> Checking PATCH 5/20: osdep: Add qemu_lock_fd and qemu_unlock_fd...
> Checking PATCH 6/20: raw-posix: Add image locking support...
> Checking PATCH 7/20: qemu-io: Add "-L" option for BDRV_O_NO_LOCK...
> Checking PATCH 8/20: qemu-img: Add "-L" option to sub commands...
> Checking PATCH 9/20: qemu-img: Update documentation of "-L" option...
> Checking PATCH 10/20: qemu-nbd: Add "--no-lock/-L" option...
> Checking PATCH 11/20: block: Don't lock drive-backup target image in none 
> mode...
> Checking PATCH 12/20: qemu-iotests: 046: Move version detection out from 
> verify_io...
> Checking PATCH 13/20: qemu-iotests: Wait for QEMU processes before checking 
> image in 091...
> Checking PATCH 14/20: qemu-iotests: 030: Disable image locking when checking 
> test image...
> Checking PATCH 15/20: iotests: 087: Disable image locking in cases where file 
> is shared...
> Checking PATCH 16/20: iotests: 130: Check image info locklessly...
> ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> #47: FILE: tests/qemu-iotests/130.out:13:
> +(qemu) q
>          ^
> 
> ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> #55: FILE: tests/qemu-iotests/130.out:20:
> +(qemu) q
>          ^

And this one seems harmless.

Fam