Re: [Qemu-devel] [PULL for-2.7 0/4] Error reporting patches for 2016-08-08

[Fam Zheng]

On Mon, 08/08 16:58, Markus Armbruster wrote:
> Automated trivial patch checking at work, woot!
> 
> I dropped address@hidden manually.
> Fam, you might want to add a Reply-to: header.
> 
> address@hidden writes:
> 
> > Hi,
> >
> > Your series seems to have some coding style problems. See output below for
> > more information:
> >
> > Message-id: address@hidden
> > Type: series
> > Subject: [Qemu-devel] [PULL for-2.7 0/4] Error reporting patches for 
> > 2016-08-08
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> >
> > BASE=base
> > n=1
> > total=$(git log --oneline $BASE.. | wc -l)
> > failed=0
> >
> > commits="$(git log --format=%H --reverse $BASE..)"
> > for c in $commits; do
> >     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s 
> > $c)..."
> >     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> > then
> >         failed=1
> >         echo
> >     fi
> >     n=$((n+1))
> > done
> >
> > exit $failed
> > === TEST SCRIPT END ===
> >
> > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> > From https://github.com/patchew-project/qemu
> >  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> > Switched to a new branch 'test'
> > ab5847c error: Fix error_printf() calls lacking newlines
> > 51b0c39 vfio: Use error_report() instead of error_printf() for errors
> > 5c88cff checkpatch: Fix newline detection in error_setg() & friends
> > b194612 error: Strip trailing '\n' from error string arguments (again)
> >
> > === OUTPUT BEGIN ===
> > Checking PATCH 1/4: error: Strip trailing '\n' from error string arguments 
> > (again)...
> > Checking PATCH 2/4: checkpatch: Fix newline detection in error_setg() & 
> > friends...
> > ERROR: code indent should never use tabs
> > #27: FILE: scripts/checkpatch.pl:2517:
> > +^I^I^I^Ierror_setg_file_open|$
> >
> > ERROR: code indent should never use tabs
> > #29: FILE: scripts/checkpatch.pl:2519:
> > +^I^I^I^Ierror_prepend|$
> >
> > ERROR: code indent should never use tabs
> > #30: FILE: scripts/checkpatch.pl:2520:
> > +^I^I^I^Ierror_reportf_err|$
> >
> > ERROR: code indent should never use tabs
> > #35: FILE: scripts/checkpatch.pl:2524:
> > +^Iif ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {$
> >
> > total: 4 errors, 0 warnings, 15 lines checked
> >
> > Your patch has style problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> >
> > Checking PATCH 3/4: vfio: Use error_report() instead of error_printf() for 
> > errors...
> > Checking PATCH 4/4: error: Fix error_printf() calls lacking newlines...
> > === OUTPUT END ===
> >
> > Test command exited with code: 1
> 
> I refrained from expanding tabs in the lines I touched.  26 out of 35
> patches touching checkpatch.pl add tabs.  1911 out of 2615
> checkpatch.pl's lines contain tabs.
> 
> Perhaps we should suppress this error for checkpatch.pl itself.  Or we
> should make up our minds once and for all to expand tabs there.

Not worth enough to pollute the git blame output IMO.

Perhaps tabs can be ignored by checkpatch.pl when the surrounding untouched
code uses tabs already? That's not an ultimate solution to the tab vs space
dilemma when writing patches to such files, but this seems a relatively
common pattern of ignored warning.

Fam