[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch() |
Date: |
Tue, 9 Aug 2016 08:50:25 -0400 (EDT) |
Hi
----- Original Message -----
> address@hidden writes:
>
> > From: Marc-André Lureau <address@hidden>
> >
> > Replace the old manual dispatch and validation code by the generic one
> > provided by qapi common code.
> >
> > Note that it is now possible to call the following commands that used to
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >
> > Their fallback functions return an appropriate "feature disabled" error.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
>
> Means query-qmp-schema no longer shows whether these commands are
> supported, doesn't it?
>
> Eric, could this create difficulties for libvirt or other introspection
> users?
Thinking a bit about this, I guess it would be fairly straightforward to have a
new key "c-conditional" : "#ifdef CONFIG_SPICE" that would prepend it in C
generated files, with a corresponding "#endif". Would that be acceptable?
- [Qemu-devel] [PATCH v3 08/15] monitor: implement 'qmp_query_commands' without qmp_cmds, (continued)
- [Qemu-devel] [PATCH v3 08/15] monitor: implement 'qmp_query_commands' without qmp_cmds, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 09/15] qapi: remove the "middle" mode, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 10/15] qapi: check invalid arguments on no-args commands, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 11/15] qmp: update qmp_query_spice fallback, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), marcandre . lureau, 2016/08/08
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Daniel P. Berrange, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(),
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/10
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/10
[Qemu-devel] [PATCH v3 13/15] build-sys: remove qmp-commands-old.h, marcandre . lureau, 2016/08/08
[Qemu-devel] [PATCH v3 15/15] qmp-commands.txt: fix some styling, marcandre . lureau, 2016/08/08
[Qemu-devel] [PATCH v3 14/15] Drop qmp-commands.hx, marcandre . lureau, 2016/08/08