Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit machines on 32 bit builds

[Alex Bennée]

Squash or move to the position before?

On 9 August 2016 at 17:15, Peter Maydell <address@hidden> wrote:
> On 9 August 2016 at 16:55, Alex Bennée <address@hidden> wrote:
>> If the user doesn't specify any targets we build a default_target_list
>> from the target .mak fragements. If we don't filter out the 64 bit
>> targets when building on 32 bit machines we'll error out later on.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>>  configure | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 7b779c1..5499dbc 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1252,7 +1252,21 @@ if [ "$bsd_user" = "yes" ]; then
>>  fi
>>
>>  for config in $mak_wilds; do
>> -    default_target_list="${default_target_list} $(basename "$config" .mak)"
>> +
>> +    target=$(basename "$config" .mak)
>> +
>> +    if test "$cpu_width" = "32"; then
>> +        case $target in
>> +            *64*|s390x-*)
>> +                # skip 64 bit machines
>> +                ;;
>> +            *)
>> +                default_target_list="${default_target_list} ${target}"
>> +                ;;
>> +        esac
>> +    else
>> +        default_target_list="${default_target_list} ${target}"
>> +    fi
>>  done
>
> Ah, this is where the default target list gets updated.
> You need to squash this into patch 1 or you break bisection
> on 32-bit hosts.
>
> thanks
> -- PMM



-- 
Alex Bennée
KVM/QEMU Hacker for Linaro