qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit machines on


From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit machines on 32 bit builds
Date: Tue, 9 Aug 2016 20:11:16 +0100

On 9 August 2016 at 20:08, Alex Bennée <address@hidden> wrote:
> Squash or move to the position before?

There's not much code here and in any case it assumes
the existence of variables only set in the previous
patch, so I'd just squash.

PS:

>>> +    if test "$cpu_width" = "32"; then
>>> +        case $target in
>>> +            *64*|s390x-*)
>>> +                # skip 64 bit machines

...this is adding another place that's listing all 64-bit
targets and which would need to be changed if we add another
64-bit target in future.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]