qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure c


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure command line
Date: Wed, 10 Aug 2016 03:09:57 -0400 (EDT)

> On Tue, 08/09 17:21, Paolo Bonzini wrote:
> > On 05/08/2016 11:04, Fam Zheng wrote:
> > > We don't have .git in the docker checkout, add this to enable -Werror
> > > explicitly.
> > > 
> > > Signed-off-by: Fam Zheng <address@hidden>
> > > Message-id: address@hidden
> > > ---
> > >  tests/docker/common.rc | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> > > index 77069e1..0c6d8d5 100755
> > > --- a/tests/docker/common.rc
> > > +++ b/tests/docker/common.rc
> > > @@ -24,6 +24,7 @@ requires()
> > >  build_qemu()
> > >  {
> > >      $QEMU_SRC/configure \
> > > +        --enable-werror \
> > >          ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> > >          --prefix="$PWD/install" \
> > >          $EXTRA_CONFIGURE_OPTS \
> > > 
> > 
> > centos6 has -Wuninitialized errors.  Should this be applied only to
> > Fedora and Ubuntu?
> 
> That way I think build_qemu can be made sensible to the env. For now I'm not
> seeing any compiling failure with centos6, even though this patch is already
> merged.  Do you mean this is a potential false alarm?

I don't know... I remember seeing some, but now I don't see any failure.
Perhaps this is because of --enable-debug?  Uninitialized variables require
optimization.  But CentOS 6 should have _FORTIFY_SOURCE and thus should
enable optimization.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]