Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors

[Cornelia Huck]

On Tue,  9 Aug 2016 17:47:43 +0200
Paolo Bonzini <address@hidden> wrote:

> This only leaves a warning-level message for extra-long lines, which
> are relatively common and cause patchew to send email that will likely
> be ignored.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  scripts/checkpatch.pl | 66 
> +++++++++++++++++++++++++--------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 

>  # no volatiles please
>               my $asm_volatile = 
> qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
>               if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
> -                     WARN("Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt\n" . $herecurr);
> +                     ERROR("Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt\n" . $herecurr);

It's a bit weird to have this refer to a Linux file :)