qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
Date: Wed, 10 Aug 2016 09:48:28 +0200

On Wed, 10 Aug 2016 03:08:33 -0400 (EDT)
Paolo Bonzini <address@hidden> wrote:

> > Paolo Bonzini <address@hidden> writes:
> > 
> > > This only leaves a warning-level message for extra-long lines, which
> > > are relatively common and cause patchew to send email that will likely
> > > be ignored.
> > >
> > > Signed-off-by: Paolo Bonzini <address@hidden>
> > 
> > Are we ready to give up on illegibly long lines?
> 
> We have other levels of code review than checkpatch.  80 chars can be
> illegibly short in some circumstances where 83 or 84 are enough.

We could leave the WARN at 80 chars and add an error at 120 chars or so.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]