[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors |
Date: |
Wed, 10 Aug 2016 03:58:31 -0400 (EDT) |
----- Original Message -----
> From: "Cornelia Huck" <address@hidden>
> To: "Paolo Bonzini" <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden, address@hidden
> Sent: Wednesday, August 10, 2016 9:46:14 AM
> Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
>
> On Tue, 9 Aug 2016 17:47:43 +0200
> Paolo Bonzini <address@hidden> wrote:
>
> > This only leaves a warning-level message for extra-long lines, which
> > are relatively common and cause patchew to send email that will likely
> > be ignored.
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> > scripts/checkpatch.pl | 66
> > +++++++++++++++++++++++++--------------------------
> > 1 file changed, 33 insertions(+), 33 deletions(-)
> >
>
> > # no volatiles please
> > my $asm_volatile =
> > qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
> > if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
> > - WARN("Use of volatile is usually wrong: see
> > Documentation/volatile-considered-harmful.txt\n" . $herecurr);
> > + ERROR("Use of volatile is usually wrong: see
> > Documentation/volatile-considered-harmful.txt\n" . $herecurr);
>
> It's a bit weird to have this refer to a Linux file :)
Right. We should include the explanation in docs/atomics.txt and point
to that.
Paolo
[Qemu-devel] [PATCH 3/3] checkpatch: default to success if only warnings, Paolo Bonzini, 2016/08/09
Re: [Qemu-devel] [PATCH 0/3] checkpatch tweaks, Fam Zheng, 2016/08/09
Re: [Qemu-devel] [PATCH 0/3] checkpatch tweaks, Cornelia Huck, 2016/08/10