[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] CODING_STYLE, checkpatch: update line lengt
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] CODING_STYLE, checkpatch: update line length rules |
Date: |
Wed, 10 Aug 2016 11:01:21 +0200 |
On Wed, 10 Aug 2016 10:22:48 +0200
Paolo Bonzini <address@hidden> wrote:
> Line lengths above 80 characters do exist. They are rare, but
> they happen from time to time. An ignored rule is worse than an
> exception to the rule, so do the latter.
>
> Some on the list expressed their preference for a soft limit that
> is slightly lower than 80 characters, to account for extra characters
> in unified diffs (including three-way diffs) and for email quoting.
> However, there was no consensus on this so keep the 80-character
> soft limit and add a hard limit at 90.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> CODING_STYLE | 13 ++++++++++---
> scripts/checkpatch.pl | 8 ++++++--
> 2 files changed, 16 insertions(+), 5 deletions(-)
I would prefer a slightly bigger hard limit to allow for un-split
strings, but that's pushing into bike-shed territory. We can still
revisit that any time later.
Acked-by: Cornelia Huck <address@hidden>
Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks, Markus Armbruster, 2016/08/10
Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks, no-reply, 2016/08/10