[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8 v1 17/60] trace: introduce some Makefile
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH for-2.8 v1 17/60] trace: introduce some Makefile rules for module code gen |
Date: |
Wed, 10 Aug 2016 15:48:57 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Wed, Aug 10, 2016 at 04:18:44PM +0200, Lluís Vilanova wrote:
> Daniel P Berrange writes:
> [...]
> > diff --git a/Makefile b/Makefile
> > index 48673cb..2b9ba60 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -70,9 +70,55 @@ GENERATED_SOURCES += trace/generated-helpers.c
>
> > ifeq ($(findstring ust,$(TRACE_BACKENDS)),ust)
> > GENERATED_HEADERS += trace/generated-ust-provider.h
> > +GENERATED_HEADERS += trace/generated-ust-provider-all.h
> > GENERATED_SOURCES += trace/generated-ust.c
> > endif
>
> > +GENERATED_HEADERS += $(trace-events-subdirs:%=%/trace.h)
> > +GENERATED_SOURCES += $(trace-events-subdirs:%=%/trace.c)
> > +GENERATED_DTRACE =
> > +ifdef CONFIG_TRACE_DTRACE
> > +GENERATED_HEADERS += $(trace-events-subdirs:%=%/trace-dtrace.h)
> > +GENERATED_DTRACE += $(trace-events-subdirs:%=%/trace-dtrace.dtrace)
> > +endif
> > +ifdef CONFIG_TRACE_UST
> > +GENERATED_HEADERS += $(trace-events-subdirs:%=%/trace-ust.h)
> > +endif
> > +
> > +%/trace.h: $(SRC_PATH)/%/trace-events $(tracetool-y)
> > + $(call quiet-command,$(TRACETOOL) \
> > + --format=h \
> > + --backends=$(TRACE_BACKENDS) \
> > + --group=$(shell dirname $@ | tr /- _) \
> > + < $< > $@," GEN $@")
> > +
> > +%/trace.c: $(SRC_PATH)/%/trace-events $(tracetool-y)
> > + $(call quiet-command,$(TRACETOOL) \
> > + --format=c \
> > + --backends=$(TRACE_BACKENDS) \
> > + --group=$(shell dirname $@ | tr /- _) \
> > + < $< > $@," GEN $@")
> > +
> > +%/trace-ust.h: $(SRC_PATH)/%/trace-events $(tracetool-y)
> > + $(call quiet-command,$(TRACETOOL) \
> > + --format=ust-events-h \
> > + --backends=$(TRACE_BACKENDS) \
> > + --group=$(shell dirname $@ | tr /- _) \
> > + < $< > $@," GEN $@")
> > +
> > +%/trace-dtrace.dtrace: $(SRC_PATH)/%/trace-events
> > $(BUILD_DIR)/config-host.mak $(tracetool-y)
> > + $(call quiet-command,$(TRACETOOL) \
> > + --format=d \
> > + --backends=$(TRACE_BACKENDS) \
> > + --group=$(shell dirname $@ | tr /- _) \
> > + < $< > $@," GEN $@")
> > +
> > +%/trace-dtrace.h: %/trace-dtrace.dtrace $(tracetool-y)
> > + $(call quiet-command,dtrace -o $@ -h -s $<, " GEN $@")
> > +
> > +%/trace-dtrace.o: %/trace-dtrace.dtrace $(tracetool-y)
> > +
> > +
> > # Don't try to regenerate Makefile or configure
> > # We don't generate any of them
> > Makefile: ;
>
> I'd rather keep the "generated-" prefix on all files that usually are not
> directly included by QEMU developers.
I don't think that's really needed - all these files are in sub-dirs
now and its a clear rule that trace*.[hc] is auto-generated in every
sub-dir now. Also no oither code in QEMU thats auto-generated adds
this prefix on so trace is inconsistent with practice elsewhere.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH for-2.8 v1 10/60] trace: remove fixed global event state arrays, (continued)
- [Qemu-devel] [PATCH for-2.8 v1 10/60] trace: remove fixed global event state arrays, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 12/60] trace: use -1 instead of TRACE_VCPU_EVENT_COUNT as magic value, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 14/60] trace: get rid of generated-events.h/generated-events.c, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 13/60] trace: remove generated-events.h from many includes, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 19/60] trace: switch util/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 15/60] trace: introduce a formal group name for trace events, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 17/60] trace: introduce some Makefile rules for module code gen, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 20/60] trace: switch crypto/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 16/60] trace: introduce ID range offsets per trace-events file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 22/60] trace: switch block/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 24/60] trace: switch hw/char/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 18/60] trace: switch io/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 26/60] trace: switch hw/net/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 25/60] trace: switch hw/intc/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 28/60] trace: switch hw/audio/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 30/60] trace: switch hw/usb/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 21/60] trace: switch migration/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09