qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU


From: David Kiarie
Subject: Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU
Date: Thu, 11 Aug 2016 11:32:43 +0300

On Thu, Aug 11, 2016 at 11:23 AM, Valentine Sinitsyn <
address@hidden> wrote:

> Hi,
>
>
> On 02.08.2016 13:39, David Kiarie wrote:
>
>> +static void amdvi_writeq_raw(AMDVIState *s, uint64_t val, hwaddr addr)
>> +{+
>> +static void amdvi_generate_msi_interrupt(AMDVIState *s)
>> +{
>> +    MSIMessage msg;
>> +    if (msi_enabled(&s->pci.dev)) {
>> +        msg = msi_get_message(&s->pci.dev, 0);
>> +        address_space_stl_le(&address_space_memory, msg.address,
>> msg.data,
>> +                         MEMTXATTRS_UNSPECIFIED, NULL);
>>
> Nit: don't you want to set the requester ID to the IOMMU's BDF here?


We could though I overlooked that because IOMMU interrupt requests are not
processed by IOMMU.


>
>
> Valentine
>
>>
>>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]